Feature: RDS Snapshot Attributes #7232
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #7232 +/- ##
=======================================
Coverage 95.90% 95.90%
=======================================
Files 840 840
Lines 82653 82721 +68
=======================================
+ Hits 79268 79335 +67
- Misses 3385 3386 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Hi @JoshLevyMN, Thank you again for contributing to Moto! To show our thanks, we'd like to share some of the donations that we've received with you. PR's like this are the big reason that Moto is as successful as it is - so it's only fair that you, as a contributor, get to share the spoils. We've created a companion website with more information: Feel free to open a bug or discussion if you run into any problems: |
|
This is now part of moto >= 4.2.14.dev19 |
…te values Original code raises the following at runtime: TypeError: unsupported operand type(s) for +: 'dict_values' and 'list' This change coerces both values to `list` to allow the `+` operand to succeed. It also changes the ordering so that any `values_to_add` are *appended* to the existing values NOTE: These were the only two lines not covered by tests in getmoto#7232, and they both contained bugs!
…te values Original code raises the following at runtime: TypeError: unsupported operand type(s) for +: 'dict_values' and 'list' This change coerces both values to `list` to allow the `+` operand to succeed. It also changes the ordering so that any `values_to_add` are *appended* to the existing values NOTE: These were the only two lines not covered by tests in #7232, and they both contained bugs!
Adds
describe_db_snapshot_attributes,modify_db_snapshot_attributes,describe_db_cluster_snapshot_attributes,modify_db_cluster_snapshot_attributes, methods for RDS, as well as adding/fixing thestorage_encrytedandglobal_write_forwarding_requestedparameters for RDS clusters.