Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding services to IMPLEMENTED_ENDPOINT_SERVICES, to be returned by describe_vpc_endpoint_services calls #7477

Closed

Conversation

jamesnixon-aws
Copy link

@jamesnixon-aws jamesnixon-aws commented Mar 15, 2024

Addresses: #7469

Services retrieved via a real call to describe-vpc-endpoint-services.

@jamesnixon-aws jamesnixon-aws changed the title adding services to IMPLEMENTED_ENDPOINT_SERVICES adding services to IMPLEMENTED_ENDPOINT_SERVICES, to be returned by describe_vpc_endpoint_services calls Mar 15, 2024
@jamesnixon-aws
Copy link
Author

Not sure what the test failures are caused by, but they seem unrelated to the changes. There are nested import errors for moto.accessanalyzer. Any ideas on the cause are welcome.

@bblommers
Copy link
Collaborator

Hi @jamesnixon-aws! The logic behind the implementation is basically:

for every_service in IMPLEMENTED_SERVICES:
    lazyload the service module (implementation for that service)
    request the vpc_endpoint details from that module

The errors for moto.accessanalyzer appear because Moto doesn't have a service module for most items from the list - so the call to importlib.import_module('moto.accessanalyzer') is bound to fail.

I've raised a different PR with a fix: #7509.
That implementation returns a sensible default config for services that Moto doesn't know about, and also fixes a bug where Moto would only cache service configs for a single region.

Thank you for getting started with this, and for providing the list of supported services!

@bblommers bblommers closed this Mar 22, 2024
@jamesnixon-aws jamesnixon-aws deleted the new_vpc_services branch March 22, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants