Sets autoscalinggroup CreatedTime during creation. #7478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the current time instead of hard coded '2013-05-06T17:47:15.107Z' when creating an autoscaling group. Updated template to return the correct created time. Added unit test.
Use datetime.strptime instead of datetime.fromisoformat
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7478 +/- ##
==========================================
- Coverage 95.88% 95.81% -0.08%
==========================================
Files 843 854 +11
Lines 82578 84016 +1438
==========================================
+ Hits 79178 80496 +1318
- Misses 3400 3520 +120
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
bblommers
approved these changes
Mar 16, 2024
|
This is now part of moto >= 5.0.4.dev18 |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the current time instead of hard coded '2013-05-06T17:47:15.107Z' when creating an autoscaling group.
Updated template to return the correct created time.
Added unit test.