Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ECS: tasks include containers objects #8588

Merged
merged 8 commits into from
Feb 15, 2025

Conversation

rafcio19
Copy link
Contributor

@rafcio19 rafcio19 commented Feb 12, 2025

Resolves #8319

Copy link

codecov bot commented Feb 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.66%. Comparing base (c2a0d9c) to head (7b6d6e6).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8588   +/-   ##
=======================================
  Coverage   92.66%   92.66%           
=======================================
  Files        1236     1236           
  Lines      106996   107012   +16     
=======================================
+ Hits        99149    99165   +16     
  Misses       7847     7847           
Flag Coverage Δ
servertests 28.14% <11.76%> (-0.01%) ⬇️
unittests 92.64% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rafcio19 rafcio19 marked this pull request as ready for review February 13, 2025 08:06
Copy link
Collaborator

@bblommers bblommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thank you for tackling this @rafcio19!

@bblommers bblommers added this to the 5.0.29 milestone Feb 15, 2025
@bblommers bblommers merged commit dd634d8 into getmoto:master Feb 15, 2025
56 checks passed
@rafcio19 rafcio19 deleted the ecs_containers branch February 15, 2025 15:14
@bblommers bblommers modified the milestones: 5.0.29, 5.1.0 Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ECS run_task creates no containers
2 participants