Lambda: Pick Lambda image deterministically #8603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakob-keller
force-pushed
the
deterministic-lambda-image
branch
from
fae2483 to
0aab0cd
Compare
jakob-keller
force-pushed
the
deterministic-lambda-image
branch
from
0aab0cd to
bc53e8b
Compare
jakob-keller
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8603 +/- ##
==========================================
- Coverage 92.68% 92.67% -0.01%
==========================================
Files 1242 1242
Lines 107267 107267
==========================================
- Hits 99417 99415 -2
- Misses 7850 7852 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
bblommers
approved these changes
Feb 17, 2025
There was a problem hiding this comment.
Makes sense @jakob-keller. It's a shame that Python does not have an OrderedSet, but this is a great alternative.
Thank you for the PR!
This was referenced Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #8602