Merge pull request #462 from getodk/ktuite/migrate-fail

Check for pending migrations before running server

Makefile

@@ -7,7 +7,10 @@ node_modules:
 migrations: node_modules
 	node -e 'const { withDatabase, migrate } = require("./lib/model/migrate"); withDatabase(require("config").get("default.database"))(migrate);'
 
-base: node_modules migrations
+check-migrations: node_modules
+	node -e 'const { withDatabase, checkMigrations } = require("./lib/model/migrate"); withDatabase(require("config").get("default.database"))(checkMigrations);'
+
+base: node_modules migrations check-migrations
 
 run: base
 	node lib/bin/run-server.js

lib/model/migrate.js

@@ -25,5 +25,13 @@ const withDatabase = (config) => (mutator) => {
 // Given a database, initiates migrations on it.
 const migrate = (db) => db.migrate.latest({ directory: `${__dirname}/migrations` });
 
-module.exports = { connect, withDatabase, migrate };
+// Checks for pending migrations and returns an exit code of 1 if any are
+// still pending/unapplied (e.g. automatically running migrations just failed).
+const checkMigrations = (db) => db.migrate.list({ directory: `${__dirname}/migrations` })
+  .then((res) => {
+    if (res[1].length > 0)
+      process.exitCode = 1;
+  });
+
+module.exports = { checkMigrations, connect, withDatabase, migrate };