bug: leaking database information in some problem messages.

getodk · Apr 21, 2020 · c90b095 · c90b095
1 parent 7491e51
commit c90b095
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/lib/resources/forms.js b/lib/resources/forms.js
@@ -137,7 +137,7 @@ module.exports = (service, endpoint) => {
       .then((form) => auth.canOrReject('form.update', form))
       .then(rejectIf(
         (form) => (form.draftDefId == null),
-        Problem.user.notFound
+        () => Problem.user.notFound()
       ))
       .then((form) => Promise.all([
         // TODO: for now we just cast away the draft to nothing. eventually probably sweep+delete.

diff --git a/lib/resources/submissions.js b/lib/resources/submissions.js
@@ -108,7 +108,7 @@ module.exports = (service, endpoint) => {
       .then(ensureDef)
       .then(rejectIf(
         (form) => !form.acceptsSubmissions(),
-        Problem.user.notAcceptingSubmissions
+        () => Problem.user.notAcceptingSubmissions()
       ))
       .then((form) => auth.canOrReject('submission.create', form)));
 
@@ -134,7 +134,7 @@ module.exports = (service, endpoint) => {
       .then(ensureDef)
       .then(rejectIf(
         ((form) => (params.key !== form.def.draftToken) || isBlank(form.def.draftToken)),
-        Problem.user.notFound
+        () => Problem.user.notFound()
       ));
   });
 
@@ -174,7 +174,7 @@ module.exports = (service, endpoint) => {
       .then(ensureDef)
       .then(rejectIf(
         (form) => !form.acceptsSubmissions(),
-        Problem.user.notAcceptingSubmissions
+        () => Problem.user.notAcceptingSubmissions()
       )));
 
   restSubmission('/projects/:projectId/forms/:formId/draft/submissions', ({ projectId, formId }, Form) =>