Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

breaking: Rename latest tag to nightly #370

Merged
merged 1 commit into from
Apr 4, 2022
Merged

breaking: Rename latest tag to nightly #370

merged 1 commit into from
Apr 4, 2022

Conversation

BYK
Copy link
Member

@BYK BYK commented Mar 18, 2022

Make the :latest tag on Docker Hub to mean latest release and introduce the :nightly tag for the per-master builds. This is in alignment with other Sentry projects. Should address getsentry/publish#666.

@BYK
Copy link
Member Author

BYK commented Mar 18, 2022

Would be great if someone added the "Increase Release Safety and Reliability" milestone to this PR.

@BYK
breaking: Rename latest tag to nightly
6e07a0f 
Make the `:latest` tag on Docker Hub to mean latest release and introduce the `:nightly` tag for the per-master builds. This is in alignment with other Sentry projects. Should address getsentry/publish#666.
kamilogorek
kamilogorek approved these changes Mar 21, 2022
View reviewed changes
Copy link
Contributor

@kamilogorek kamilogorek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. cc @chadwhitacre

@BYK
Copy link
Member Author

BYK commented Apr 2, 2022

Ping @kamilogorek @chadwhitacre @mitsuhiko

@kamilogorek
Copy link
Contributor

I cannot force-merge it without @chadwhitacre or @mitsuhiko :(

@BYK
Copy link
Member Author

BYK commented Apr 4, 2022

@kamilogorek you can add a comment saying /gcbrun to trigger GCB runs and can try re-running the lint job that failed. They both should pass ideally.

@kamilogorek
Copy link
Contributor

/gcbrun

@kamilogorek
Copy link
Contributor

kamilogorek commented Apr 4, 2022 •
edited
Loading

TIL about /gcbrun, linter still fails though.

@BYK
Copy link
Member Author

BYK commented Apr 4, 2022 •
edited
Loading

TIL about /gcbrun, linter still fails though.

To protect abuse Sentry protects all GCB runs that would be triggered by external parties with this. When an external party submits or updates a PR, a member of the repo should comment with /gcbrun to trigger a GCB run.

@BYK BYK closed this Apr 4, 2022
@BYK BYK reopened this Apr 4, 2022
@BYK
Copy link
Member Author

BYK commented Apr 4, 2022

And sorry, didn't mean to close/open the PR, fat fingering 😅

@BYK
Copy link
Member Author

BYK commented Apr 4, 2022

Also, since lint is not required you should be able to merge this after typing another /gcbrun.

@BYK
Copy link
Member Author

BYK commented Apr 4, 2022

@kamilogorek sent #378 to fix the lint job failure.

@kamilogorek
Copy link
Contributor

/gcbrun

@kamilogorek kamilogorek merged commit 921ebbb into getsentry:master Apr 4, 2022
@kamilogorek
Copy link
Contributor

kamilogorek commented Apr 4, 2022 •
edited
Loading

0.31.0 :shipit:

@BYK BYK deleted the byk/ref/order-66 branch April 4, 2022 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kamilogorek kamilogorek kamilogorek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Increase Release Safety and Reliability
Development

Successfully merging this pull request may close these issues.
2 participants
@BYK @kamilogorek