fix:(GitHub Auth): Deprecate getAuthUsername #585
Conversation
| if (username && apiToken) { | ||
| this.setAuth(username, apiToken); | ||
| } |
There was a problem hiding this comment.
should be able to remove these parameters entirely -- or maybe take the api key and do the header modification here?
There was a problem hiding this comment.
parameters removed, but I'm not sure how to bake the token and header in there
| * | ||
| * @returns GitHub auth header | ||
| */ | ||
| export function getGitHubAuthHeader(): Array<string> { |
There was a problem hiding this comment.
I found something arguably easier and more like the old ways here: https://stackoverflow.com/a/66156992/90297
git clone https://oauth2:[email protected]/username/repo.git
So, maybe just do that to keep things simple and hopefully more compatible?
There was a problem hiding this comment.
afaict both ways work with user tokens or app tokens -- fun fact the username does not matter for the clone-url approach just that it cannot be empty
There was a problem hiding this comment.
Wowza, alright then let's go with the old way as it seems simpler?
| * | ||
| * @returns GitHub auth header | ||
| */ | ||
| export function getGitHubAuthHeader(): Array<string> { |
There was a problem hiding this comment.
afaict both ways work with user tokens or app tokens -- fun fact the username does not matter for the clone-url approach just that it cannot be empty
Currently we are using
https://username:token@github/owner/repoto perform auth will talking to GitHub, it does not work well with GitHub Apps, hence deprecating it and bake the authentication token into authentication headers.