fix: warn about missing SENTRY_RELEASE when it's set to empty string

closes #2385
getsentry · Feb 19, 2025 · 8f2edee · 8f2edee
1 parent 6c108fb
commit 8f2edee
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/src/config.rs b/src/config.rs
@@ -363,8 +363,12 @@ impl Config {
         matches
             .get_one::<String>("release")
             .cloned()
-            .or_else(|| env::var("SENTRY_RELEASE").ok())
-            .ok_or_else(|| format_err!("A release slug is required (provide with --release)"))
+            .or_else(|| {
+                env::var("SENTRY_RELEASE")
+                    .ok()
+                    .and_then(|v| if v.is_empty() { None } else { Some(v) })
+            })
+            .ok_or_else(|| format_err!("A release slug is required (provide with --release) or set the SENTRY_RELEASE environment variable"))
     }
 
     // Backward compatibility with `releases files <VERSION>` commands.