Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(docker): Release Docker image to GHCR #2393

Merged
merged 1 commit into from
Feb 19, 2025

Conversation

szokeasaurusrex
Copy link
Member

We already build and push our Docker images to GHCR, tagged with commit hash, during the Release Build action. This PR adds two new actions which will tag these images with the version number and with the "latest" once the GitHub release is created. We have two separate actions for each, since we only want to add the "latest" tag for releases, not for preleases, but the version tag should be created for both.

Ref #1503

We already build and push our Docker images to GHCR, tagged with commit hash, during the Release Build action. This PR adds two new actions which will tag these images with the version number and with the "latest" once the GitHub release is created. We have two separate actions for each, since we only want to add the "latest" tag for releases, not for preleases, but the version tag should be created for both.

Ref #1503
Copy link
Member

@asottile-sentry asottile-sentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could probably combine the two but this works! also iirc there's a way to retag without pushing and pulling through docker manifest something something but this is probably "good enough" and works as is

@szokeasaurusrex szokeasaurusrex merged commit 5824695 into master Feb 19, 2025
14 checks passed
@szokeasaurusrex szokeasaurusrex deleted the szokeasaurusrex/ghcr-docker branch February 19, 2025 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants