Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: warn about missing SENTRY_RELEASE when it's set to empty string #2394

Merged
merged 5 commits into from
Feb 19, 2025
Merged

fix: warn about missing SENTRY_RELEASE when it's set to empty string #2394

merged 5 commits into from
Feb 19, 2025

Conversation

a-hariti
Copy link
Collaborator

I'm not sure if this covers all instances/paths

closes #2385

@szokeasaurusrex
Copy link
Member

szokeasaurusrex commented Feb 19, 2025 •
edited
Loading

@a-hariti i think this will only cover the environment variable. However, release can also be set in other ways, e.g. via command line argument. I think we should instead change where we serialize the data for the HTTP request. I would be happy to point you in the right direction.

@a-hariti
Copy link
Collaborator Author

Yes, I would love to

a-hariti
a-hariti commented Feb 19, 2025
View reviewed changes
@a-hariti
Copy link
Collaborator Author

is on this line? https://github.com/getsentry/sentry-cli/blob/master/src/utils/file_upload.rs#L99
@szokeasaurusrex

szokeasaurusrex
szokeasaurusrex reviewed Feb 19, 2025
View reviewed changes
Copy link
Member

@szokeasaurusrex szokeasaurusrex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, nice first PR! I noticed a couple small things to change before we merge, but I'll approve once those are addressed

szokeasaurusrex
szokeasaurusrex approved these changes Feb 19, 2025
View reviewed changes
Copy link
Member

@szokeasaurusrex szokeasaurusrex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@a-hariti a-hariti merged commit c7919f5 into master Feb 19, 2025
14 checks passed
@a-hariti a-hariti deleted the warn-empty-sentry-release-var branch February 19, 2025 17:51
@szokeasaurusrex szokeasaurusrex mentioned this pull request Feb 19, 2025
Open
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szokeasaurusrex szokeasaurusrex szokeasaurusrex approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sentry reported an error: '' does not match '^[^/]+$' (http status: 400)
2 participants
@a-hariti @szokeasaurusrex