Fix bundle file count report #2397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-hariti
force-pushed
the
fix-bundle-file-count-report
branch
from
9aa8ec9 to
6ed5c91
Compare
szokeasaurusrex
approved these changes
Feb 19, 2025
There was a problem hiding this comment.
Nice! If it is easy to do so, we might want to add a test for this. However, I wouldn't invest too much time into writing one if it is too much effort.
Also, prior to merging, please ensure the commit message adheres to Sentry's commit message naming guidelines. We are not super strict on this, but I have been trying to follow the guidelines in general. For this PR, I would use something like this:
fix(sourcemaps): Exclude skipped files from bundle file count
szokeasaurusrex
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
some files fail to be added to the source bundle for different errors,
but the report shows the count of the original number of file that would to be added if no errors occurred.
closes #2136