Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add manual file IO tracking for Swift.Data and Swift.FileManager #4605

Open
wants to merge 53 commits into
base: main
Choose a base branch
from

Merge remote-tracking branch 'origin/main' into philprime/file-io-tra…

e4be2f7
Select commit
Loading
Failed to load commit list.
Open

feat: Add manual file IO tracking for Swift.Data and Swift.FileManager #4605

Merge remote-tracking branch 'origin/main' into philprime/file-io-tra…
e4be2f7
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Feb 18, 2025 in 1s

92.395% (+0.231%) compared to 43a41b3

View this Pull Request on Codecov

92.395% (+0.231%) compared to 43a41b3

Details

Codecov Report

Attention: Patch coverage is 99.55668% with 7 lines in your changes missing coverage. Please review.

Project coverage is 92.395%. Comparing base (43a41b3) to head (e4be2f7).

Files with missing lines Patch % Lines
...ance/IO/SentryFileIOTrackingIntegrationTests.swift 98.104% 4 Missing ⚠️
Sources/Sentry/SentryFileIOTracker.m 97.674% 0 Missing and 1 partial ⚠️
...ormance/IO/DataSentryTracingIntegrationTests.swift 99.500% 1 Missing ⚠️
...ions/Performance/IO/SentryFileIOTrackerTests.swift 99.090% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #4605       +/-   ##
=============================================
+ Coverage   92.164%   92.395%   +0.231%     
=============================================
  Files          658       664        +6     
  Lines        77222     78688     +1466     
  Branches     27170     28579     +1409     
=============================================
+ Hits         71171     72704     +1533     
+ Misses        5957      5887       -70     
- Partials        94        97        +3     
Files with missing lines Coverage Δ
Sources/Sentry/SentryDependencyContainer.m 96.835% <100.000%> (+0.124%) ⬆️
Sources/Sentry/SentryFileIOTrackingIntegration.m 100.000% <100.000%> (ø)
Sources/Sentry/SentryNSDataSwizzling.m 100.000% <100.000%> (ø)
Sources/Sentry/SentryNSFileManagerSwizzling.m 100.000% <100.000%> (+47.058%) ⬆️
...tegrations/Performance/IO/Data+SentryTracing.swift 100.000% <100.000%> (ø)
...ons/Performance/IO/FileManager+SentryTracing.swift 100.000% <100.000%> (ø)
...formance/IO/SentryFileIOTracker+SwiftHelpers.swift 100.000% <100.000%> (ø)
Sources/Swift/SentryExperimentalOptions.swift 50.000% <100.000%> (+16.666%) ⬆️
...rmance/IO/FileManagerTracingIntegrationTests.swift 100.000% <100.000%> (ø)
.../SentryTests/Transactions/SentrySpanKeyTests.swift 100.000% <100.000%> (ø)
... and 6 more

... and 30 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43a41b3...e4be2f7. Read the comment docs.