-
-
Notifications
You must be signed in to change notification settings - Fork 341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Report fatal app hangs for V2 #4889
base: main
Are you sure you want to change the base?
Conversation
This PR reports fatal app hangs without session updates, only when the experimental option enableAppHangTrackingV2 is enabled. Updating the session will be done in a follow-up PR. This fixes the first part of GH-4260.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4889 +/- ##
=============================================
+ Coverage 92.369% 92.399% +0.029%
=============================================
Files 659 660 +1
Lines 77548 77806 +258
Branches 28079 28207 +128
=============================================
+ Hits 71631 71892 +261
+ Misses 5821 5817 -4
- Partials 96 97 +1
... and 13 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
26530fe | 1233.98 ms | 1250.06 ms | 16.08 ms |
6610ef1 | 1220.33 ms | 1225.61 ms | 5.28 ms |
7fb7afb | 1202.18 ms | 1219.42 ms | 17.24 ms |
b8dd0fc | 1235.57 ms | 1253.12 ms | 17.55 ms |
443723a | 1205.24 ms | 1220.52 ms | 15.28 ms |
2b19b82 | 1226.73 ms | 1243.27 ms | 16.53 ms |
4be2b3c | 1220.47 ms | 1223.88 ms | 3.41 ms |
5d6ce0e | 1227.57 ms | 1241.08 ms | 13.51 ms |
9dbf743 | 1252.10 ms | 1262.10 ms | 10.00 ms |
e34db45 | 1211.48 ms | 1224.45 ms | 12.97 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
26530fe | 21.58 KiB | 714.93 KiB | 693.35 KiB |
6610ef1 | 21.58 KiB | 699.25 KiB | 677.67 KiB |
7fb7afb | 20.76 KiB | 419.70 KiB | 398.94 KiB |
b8dd0fc | 20.76 KiB | 401.39 KiB | 380.63 KiB |
443723a | 20.76 KiB | 414.44 KiB | 393.68 KiB |
2b19b82 | 21.58 KiB | 542.18 KiB | 520.60 KiB |
4be2b3c | 20.76 KiB | 393.37 KiB | 372.61 KiB |
5d6ce0e | 22.85 KiB | 405.38 KiB | 382.53 KiB |
9dbf743 | 20.76 KiB | 434.94 KiB | 414.18 KiB |
e34db45 | 21.58 KiB | 671.30 KiB | 649.72 KiB |
📜 Description
This PR reports fatal app hangs without session updates, only when the experimental option enableAppHangTrackingV2 is enabled. Updating the session will be done in a follow-up PR.
💡 Motivation and Context
This fixes the first part of GH-4260.
💚 How did you test it?
Unit tests and an archived build distributed for development cause the watchdog doesn't terminate debug builds or simply takes a very long time to do that.
https://sentry-sdks.sentry.io/issues/6328843559/events/c79567d75edf48299845a55e2063a700/?project=5428557

https://sentry-sdks.sentry.io/issues/6328844382/events/8f9916263d124370b28d434f1647133d/?project=5428557

📝 Checklist
You have to check all boxes before merging:
sendDefaultPII
is enabled.🔮 Next steps
I will update the docs for fatal app hangs after I added the session updates.