Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: Rename SentryCrashIntegrationSessionHandler #4893

Merged
merged 1 commit into from
Feb 25, 2025

Conversation

philipphofmann
Copy link
Member

Rename from SentrySessionCrashedHandler to
SentryCrashIntegrationSessionHandler, as we're going to so we can add more logic to it, which isn't only related to crashed sessions.

Required for GH-4260.

#skip-changelog

Rename from SentrySessionCrashedHandler to
SentryCrashIntegrationSessionHandler, as we're going to so we can add
more logic to it, which isn't only related to crashed sessions.
Copy link

codecov bot commented Feb 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.271%. Comparing base (124e4ab) to head (0c5b456).
Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #4893       +/-   ##
=============================================
- Coverage   92.372%   92.271%   -0.102%     
=============================================
  Files          659       659               
  Lines        77540     77530       -10     
  Branches     28085     27291      -794     
=============================================
- Hits         71626     71538       -88     
- Misses        5818      5897       +79     
+ Partials        96        95        -1     
Files with missing lines Coverage Δ
Sources/Sentry/SentryCrashIntegration.m 99.159% <100.000%> (ø)
...rces/Sentry/SentryCrashIntegrationSessionHandler.m 96.551% <ø> (ø)

... and 26 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 124e4ab...0c5b456. Read the comment docs.

Copy link
Contributor

@philprime philprime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@philipphofmann philipphofmann merged commit fef57d6 into main Feb 25, 2025
71 of 74 checks passed
@philipphofmann philipphofmann deleted the ref/rename-crash-integration-session-handler branch February 25, 2025 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants