ci: upgrade testflight workflow macos image #4900
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armcknight
requested review from
philipphofmann and
philprime
as code owners
philprime
reviewed
Feb 26, 2025
philprime
approved these changes
Feb 26, 2025
|
I merged this cause we're getting annoying emails from Apple telling us we should compile the sample app with iOS 18. |
| @@ -19,7 +19,7 @@ on: | |||
| jobs: | |||
| upload_to_testflight: | |||
| name: Build and Upload iOS-Swift to Testflight | |||
| runs-on: macos-13 | |||
| runs-on: macos-14 | |||
| steps: | |||
| - uses: actions/checkout@v4 | |||
| - run: ./scripts/ci-select-xcode.sh 15.2 | |||
There was a problem hiding this comment.
We also need to switch to Xcode 16.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got the TestFlight emails for the iOS-Swift sample app, which contained:
We use
macos-13which only supports up to iOS 17.2. Upgrading tomacos-14satisfies the requirement to support 18.#skip-changelog