Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap up continuous profiling #4069

Open
wants to merge 4 commits into
base: feat/continuous-profiling-part1
Choose a base branch
from

Conversation

stefanosiano
Copy link
Member

@stefanosiano stefanosiano commented Jan 20, 2025

📜 Description

Last changes in order to have working continuous profiling on Android.
There is still a backend fix that needs to be deployed before testing it out completely

#skip-changelog

💡 Motivation and Context

Last part of #3710

💚 How did you test it?

📝 Checklist

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Copy link
Contributor

github-actions bot commented Jan 20, 2025

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 6eeed8e

Copy link
Contributor

github-actions bot commented Jan 20, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 411.35 ms 428.56 ms 17.21 ms
Size 1.65 MiB 2.31 MiB 681.50 KiB

Previous results on branch: feat/continuous-profiling-wrapup

Startup times

Revision Plain With Sentry Diff
79f2c66 409.12 ms 460.06 ms 50.94 ms
a82f345 497.67 ms 603.94 ms 106.27 ms

App size

Revision Plain With Sentry Diff
79f2c66 1.65 MiB 2.31 MiB 681.47 KiB
a82f345 1.65 MiB 2.31 MiB 681.47 KiB

@stefanosiano stefanosiano marked this pull request as ready for review January 24, 2025 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant