Skip to content

Commit

Permalink
ci: Show what size limit jobs exceeded the limit (#13532)
Browse files Browse the repository at this point in the history
Noticed that it was a bit annoying, when we exceeded the size limit, to
find out why/what has failed.

Now, it should show in the GH comment which specific check has failed,
and what the current limit is:


![image](https://github.com/user-attachments/assets/13495922-ac91-42bf-a398-18bb7b0e9e72)

While I was at this, I also streamlined the code a bit, extracted it a
bit into utils to de-clutter stuff, and fixed/improved some debug
logging issues (e.g. the log group was not correctly closed before, ...)
  • Loading branch information
mydea authored Sep 3, 2024
1 parent b7d1544 commit 3180113
Show file tree
Hide file tree
Showing 4 changed files with 312 additions and 274 deletions.
2 changes: 1 addition & 1 deletion dev-packages/size-limit-gh-action/.eslintrc.cjs
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ module.exports = {

overrides: [
{
files: ['*.mjs'],
files: ['**/*.mjs'],
extends: ['@sentry-internal/sdk/src/base'],
},
],
Expand Down
Loading

0 comments on commit 3180113

Please sign in to comment.