Add PW debug

getsentry · Sep 4, 2024 · 414d54c · 414d54c
1 parent 077247a
commit 414d54c
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/dev-packages/e2e-tests/test-applications/solidstart/package.json b/dev-packages/e2e-tests/test-applications/solidstart/package.json
@@ -12,7 +12,7 @@
     ],
     "preview": "HOST=localhost PORT=3030 NODE_OPTIONS='--import ./src/instrument.server.mjs' vinxi dev",
     "start": "HOST=localhost PORT=3030 NODE_OPTIONS='--import ./src/instrument.server.mjs' vinxi start",
-    "test:prod": "TEST_ENV=production playwright test",
+    "test:prod": "DEBUG=pw:api TEST_ENV=production playwright test",
     "test:build": "pnpm install && npx playwright install && pnpm build",
     "test:assert": "pnpm test:prod"
   },

diff --git a/dev-packages/e2e-tests/test-applications/solidstart/tests/errorboundary.test.ts b/dev-packages/e2e-tests/test-applications/solidstart/tests/errorboundary.test.ts
@@ -10,7 +10,7 @@ test('captures an exception', async ({ page }) => {
     );
   });
 
-  await page.goto('/client-error');
+  await page.goto('/client-error', { waitUntil: 'networkidle' });
   await page.locator('#caughtErrorBtn').click();
   const errorEvent = await errorEventPromise;
 

diff --git a/packages/solidstart/src/vite/sentrySolidStartVite.ts b/packages/solidstart/src/vite/sentrySolidStartVite.ts
@@ -8,11 +8,11 @@ import type { SentrySolidStartPluginOptions } from './types';
 export const sentrySolidStartVite = (options: SentrySolidStartPluginOptions): Plugin[] => {
   const sentryPlugins: Plugin[] = [];
 
-  // if (process.env.NODE_ENV !== 'development') {
-  if (options.sourceMapsUploadOptions?.enabled ?? true) {
-    sentryPlugins.push(...makeSourceMapsVitePlugin(options));
+  if (process.env.NODE_ENV !== 'development') {
+    if (options.sourceMapsUploadOptions?.enabled ?? true) {
+      sentryPlugins.push(...makeSourceMapsVitePlugin(options));
+    }
   }
-  // }
 
   return sentryPlugins;
 };