Skip to content

Commit

Permalink
fix(node): Replace dashes in generic-pool span origins with undersc…
Browse files Browse the repository at this point in the history
…ores (#13579)

Ref
#13465 (comment)
  • Loading branch information
lforst authored Sep 4, 2024
1 parent 6dc8aab commit 50589cd
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -11,18 +11,18 @@ describe('genericPool auto instrumentation', () => {
spans: expect.arrayContaining([
expect.objectContaining({
description: expect.stringMatching(/^generic-pool\.ac?quire/),
origin: 'auto.db.otel.generic-pool',
origin: 'auto.db.otel.generic_pool',
data: {
'sentry.origin': 'auto.db.otel.generic-pool',
'sentry.origin': 'auto.db.otel.generic_pool',
},
status: 'ok',
}),

expect.objectContaining({
description: expect.stringMatching(/^generic-pool\.ac?quire/),
origin: 'auto.db.otel.generic-pool',
origin: 'auto.db.otel.generic_pool',
data: {
'sentry.origin': 'auto.db.otel.generic-pool',
'sentry.origin': 'auto.db.otel.generic_pool',
},
status: 'ok',
}),
Expand Down
2 changes: 1 addition & 1 deletion packages/node/src/integrations/tracing/genericPool.ts
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ const _genericPoolIntegration = (() => {
spanDescription === 'generic-pool.aquire' || spanDescription === 'generic-pool.acquire';

if (isGenericPoolSpan) {
span.setAttribute(SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN, 'auto.db.otel.generic-pool');
span.setAttribute(SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN, 'auto.db.otel.generic_pool');
}
});
},
Expand Down

0 comments on commit 50589cd

Please sign in to comment.