Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(replay): Add experimental option to allow for a checkout every 6 minutes #13069

Merged
merged 5 commits into from
Sep 10, 2024

Conversation

billyvg
Copy link
Member

@billyvg billyvg commented Jul 26, 2024

Including more checkouts will improve replayer scrubbing since it will reduce the number of mutations that need to be processed (especially for longer replays). The downside is that it will increase the size of replays since we will have up to 9 more snapshots per replay (max replay duration is 60 minutes / 6 minute checkouts).

Copy link
Contributor

github-actions bot commented Jul 26, 2024

size-limit report 📦

⚠️ Warning: Base artifact is not the latest one, because the latest workflow run is not done yet. This may lead to incorrect results. Try to re-run all tests to get up to date results.

Path Size % Change Change
@sentry/browser 22.52 KB -0.01% -1 B 🔽
@sentry/browser - with treeshaking flags 21.3 KB -0.01% -1 B 🔽
@sentry/browser (incl. Tracing) 34.78 KB - -
@sentry/browser (incl. Tracing, Replay) 71.24 KB +0.02% +14 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 61.69 KB +0.05% +26 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas) 75.59 KB +0.02% +15 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback) 88.32 KB +0.03% +19 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback, metrics) 90.16 KB +0.03% +19 B 🔺
@sentry/browser (incl. metrics) 26.83 KB -0.01% -1 B 🔽
@sentry/browser (incl. Feedback) 39.6 KB -0.01% -1 B 🔽
@sentry/browser (incl. sendFeedback) 27.19 KB -0.01% -1 B 🔽
@sentry/browser (incl. FeedbackAsync) 31.9 KB - -
@sentry/react 25.28 KB -0.01% -1 B 🔽
@sentry/react (incl. Tracing) 37.75 KB -0.01% -1 B 🔽
@sentry/vue 26.72 KB - -
@sentry/vue (incl. Tracing) 36.66 KB - -
@sentry/svelte 22.65 KB - -
CDN Bundle 23.77 KB - -
CDN Bundle (incl. Tracing) 36.49 KB - -
CDN Bundle (incl. Tracing, Replay) 70.95 KB +0.06% +39 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) 76.26 KB +0.05% +38 B 🔺
CDN Bundle - uncompressed 69.63 KB - -
CDN Bundle (incl. Tracing) - uncompressed 108.2 KB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 219.98 KB +0.06% +115 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 233.18 KB +0.05% +115 B 🔺
@sentry/nextjs (client) 37.51 KB -0.01% -1 B 🔽
@sentry/sveltekit (client) 35.36 KB -0.01% -1 B 🔽
@sentry/node 120.5 KB -0.01% -1 B 🔽
@sentry/node - without tracing 92.78 KB -0.01% -2 B 🔽
@sentry/aws-serverless 102.49 KB -0.01% -1 B 🔽

View base workflow run

@billyvg billyvg force-pushed the feat-replay-add-experimental-option-checkout-every branch from 48c7dbc to e19f4fc Compare July 26, 2024 16:26
@mydea
Copy link
Member

mydea commented Jul 29, 2024

The downside is that it will increase the size of replays since we will have up to 9 more snapshots per replay (max replay duration is 60 minutes / 6 minute checkouts).

Just for understanding sake, "increase the size of replays" --> does this refer to the size sent over the network, or the size saved at Sentry (or both)? 😅

@billyvg
Copy link
Member Author

billyvg commented Jul 29, 2024

The downside is that it will increase the size of replays since we will have up to 9 more snapshots per replay (max replay duration is 60 minutes / 6 minute checkouts).

Just for understanding sake, "increase the size of replays" --> does this refer to the size sent over the network, or the size saved at Sentry (or both)? 😅

Both - snapshots will generally be larger and has "duplicate" data which end user will need to send. It'll also be saved to Sentry as part of the replay.

@billyvg billyvg marked this pull request as ready for review July 29, 2024 15:01
@billyvg billyvg requested a review from a team as a code owner July 29, 2024 15:01
//
// `isCheckout` is always true, but want to be explicit that it should
// only be added for checkouts
addSettingsEvent(replay, isCheckout);
if (session && session.segmentId === 0) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we already guard this in the addSettingsEvent method? If we guard it here we can remove that check from there instead!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh, let's keep the guard in there, in case we end up calling addSettingsEvent elsewhere.

… minutes

Including more checkouts will improve replayer scrubbing since it will reduce the number of mutations that need to be processed (especially for longer replays). The downside is that it will increase the size of replays since we will have up to 9 more snapshots per replay (max replay duration is 60 minutes / 6 minute checkouts).
@billyvg billyvg force-pushed the feat-replay-add-experimental-option-checkout-every branch from 687d287 to 9014dbc Compare July 29, 2024 19:52
@billyvg billyvg requested a review from mydea July 30, 2024 18:12
@billyvg billyvg requested a review from a team September 5, 2024 18:09
@billyvg billyvg merged commit e944daa into develop Sep 10, 2024
126 checks passed
@billyvg billyvg deleted the feat-replay-add-experimental-option-checkout-every branch September 10, 2024 20:36
alexandresoro pushed a commit to alexandresoro/ouca that referenced this pull request Sep 23, 2024
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [@sentry/node](https://github.com/getsentry/sentry-javascript/tree/master/packages/node) ([source](https://github.com/getsentry/sentry-javascript)) | dependencies | minor | [`8.30.0` -> `8.31.0`](https://renovatebot.com/diffs/npm/@sentry%2fnode/8.30.0/8.31.0) |
| [@sentry/react](https://github.com/getsentry/sentry-javascript/tree/master/packages/react) ([source](https://github.com/getsentry/sentry-javascript)) | dependencies | minor | [`8.30.0` -> `8.31.0`](https://renovatebot.com/diffs/npm/@sentry%2freact/8.30.0/8.31.0) |

---

### Release Notes

<details>
<summary>getsentry/sentry-javascript (@&#8203;sentry/node)</summary>

### [`v8.31.0`](https://github.com/getsentry/sentry-javascript/blob/HEAD/CHANGELOG.md#8310)

[Compare Source](getsentry/sentry-javascript@8.30.0...8.31.0)

##### Important Changes

-   **feat(node): Add `dataloader` integration ([#&#8203;13664](getsentry/sentry-javascript#13664

This release adds a new integration for the [`dataloader` package](https://www.npmjs.com/package/dataloader). The Node
SDK (and all SDKs that depend on it) will now automatically instrument `dataloader` instances. You can also add it
manually:

```js
Sentry.init({
  integrations: [Sentry.dataloaderIntegration()],
});
```

##### Other Changes

-   feat(browser): Add navigation `activationStart` timestamp to pageload span ([#&#8203;13658](getsentry/sentry-javascript#13658))
-   feat(gatsby): Add optional `deleteSourcemapsAfterUpload` ([#&#8203;13610](getsentry/sentry-javascript#13610))
-   feat(nextjs): Give app router prefetch requests a `http.server.prefetch` op ([#&#8203;13600](getsentry/sentry-javascript#13600))
-   feat(nextjs): Improve Next.js serverside span data quality ([#&#8203;13652](getsentry/sentry-javascript#13652))
-   feat(node): Add `disableInstrumentationWarnings` option ([#&#8203;13693](getsentry/sentry-javascript#13693))
-   feat(nuxt): Adding `experimental_basicServerTracing` option to Nuxt module ([#&#8203;13643](getsentry/sentry-javascript#13643))
-   feat(nuxt): Improve logs about adding Node option 'import' ([#&#8203;13726](getsentry/sentry-javascript#13726))
-   feat(replay): Add `onError` callback + other small improvements to debugging ([#&#8203;13721](getsentry/sentry-javascript#13721))
-   feat(replay): Add experimental option to allow for a checkout every 6 minutes ([#&#8203;13069](getsentry/sentry-javascript#13069))
-   feat(wasm): Unconditionally parse instruction addresses ([#&#8203;13655](getsentry/sentry-javascript#13655))
-   fix: Ensure all logs are wrapped with `consoleSandbox` ([#&#8203;13690](getsentry/sentry-javascript#13690))
-   fix(browser): Try multiple options for `lazyLoadIntegration` script parent element lookup ([#&#8203;13717](getsentry/sentry-javascript#13717))
-   fix(feedback): Actor color applies to feedback icon ([#&#8203;13702](getsentry/sentry-javascript#13702))
-   fix(feedback): Fix form width on mobile devices ([#&#8203;13068](getsentry/sentry-javascript#13068))
-   fix(nestjs): Preserve original function name on `SentryTraced` functions ([#&#8203;13684](getsentry/sentry-javascript#13684))
-   fix(node): Don't overwrite local variables for re-thrown errors ([#&#8203;13644](getsentry/sentry-javascript#13644))
-   fix(normalize): Treat Infinity as NaN both are non-serializable numbers ([#&#8203;13406](getsentry/sentry-javascript#13406))
-   fix(nuxt): Use correct server output file path ([#&#8203;13725](getsentry/sentry-javascript#13725))
-   fix(opentelemetry): Always use active span in `Propagator.inject` ([#&#8203;13381](getsentry/sentry-javascript#13381))
-   fix(replay): Fixes potential out-of-order segments ([#&#8203;13609](getsentry/sentry-javascript#13609))

Work in this release was contributed by [@&#8203;KyGuy2002](https://github.com/KyGuy2002), [@&#8203;artzhookov](https://github.com/artzhookov), and [@&#8203;julianCast](https://github.com/julianCast). Thank you for your contributions!

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC45My41IiwidXBkYXRlZEluVmVyIjoiMzguOTMuNSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiZGVwZW5kZW5jaWVzIl19-->

Reviewed-on: https://git.tristess.app/alexandresoro/ouca/pulls/149
Reviewed-by: Alexandre Soro <[email protected]>
Co-authored-by: renovate <[email protected]>
Co-committed-by: renovate <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants