Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tracing): make long animation frames opt-out #13255

Merged
merged 7 commits into from
Aug 9, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/browser/src/tracing/browserTracingIntegration.ts
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@
instrumentPageLoad: true,
markBackgroundSpan: true,
enableLongTask: true,
enableLongAnimationFrame: false,
enableLongAnimationFrame: true,
enableInp: true,
_experiments: {},
...defaultRequestInstrumentationOptions,
Expand Down Expand Up @@ -213,7 +213,7 @@
startTrackingINP();
}

if (enableLongAnimationFrame && PerformanceObserver.supportedEntryTypes.includes('long-animation-frame')) {

Check failure on line 216 in packages/browser/src/tracing/browserTracingIntegration.ts

View workflow job for this annotation

GitHub Actions / Browser Unit Tests

test/profiling/integration.test.ts > BrowserProfilingIntegration > pageload profiles follow regular transaction code path

ReferenceError: PerformanceObserver is not defined ❯ Module.browserTracingIntegration src/tracing/browserTracingIntegration.ts:216:35 ❯ test/profiling/integration.test.ts:52:29

Check failure on line 216 in packages/browser/src/tracing/browserTracingIntegration.ts

View workflow job for this annotation

GitHub Actions / Browser Unit Tests

test/tracing/browserTracingIntegration.test.ts > browserTracingIntegration > works with tracing enabled

ReferenceError: PerformanceObserver is not defined ❯ Module.browserTracingIntegration src/tracing/browserTracingIntegration.ts:216:35 ❯ test/tracing/browserTracingIntegration.test.ts:89:24
startTrackingLongAnimationFrames();
} else if (enableLongTask) {
startTrackingLongTasks();
Expand Down
Loading