fix(ci): Bring back job skipping for PRs without code changes #13340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lms24
force-pushed
the
lms/ci-no-code-changes
branch
from
8f4acfc
to
1ceadcb
Compare
Lms24
changed the title
size-limit report 📦
|
mydea
reviewed
Aug 13, 2024
| @@ -123,6 +127,7 @@ jobs: | |||
| runs-on: ubuntu-20.04 | |||
| timeout-minutes: 15 | |||
| if: | | |||
| (needs.job_get_metadata.outputs.changed_any_code) && | |||
There was a problem hiding this comment.
Suggested change
| (needs.job_get_metadata.outputs.changed_any_code) && | |
| needs.job_get_metadata.outputs.changed_any_code && |
There was a problem hiding this comment.
whoops, missed this but applied the suggestion in #13353
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings back the mechanism to skip running most CI jobs if only markdown files were changed in the PR.
This saves a lot of time for external contributor PRs and of course for changelog entry PRs.