ci: Stabilize CI dependency cache key #13401
Conversation
Ensure it only changes if actual dependencies change.
mydea
requested review from
lforst,
Lms24,
AbhiPrasad,
chargome and
andreiborza
mydea
changed the title
| .sort() | ||
| .forEach(key => { | ||
| // If the dependency is a workspace package, ignore the version | ||
| // No need to invalidate a cache after every release |
There was a problem hiding this comment.
doesn't this mean that we might have outdated internal code in the cache?
There was a problem hiding this comment.
this is the cache key to cache the node_modules folder. So all the workspace packages should not be there at all, so the version should not matter (I think? at least 😅 )
There was a problem hiding this comment.
👍 yeah I just wasn't sure how these workspace packages are handled within node modules
There was a problem hiding this comment.
Hmm, it's a good question 🤔 there are only some symlinks in there, but these should not change I believe between versions. IMHO we can try it and if there are problems we can revisit this particular check - but I'd expect it to be OK. We do capture added internal dependencies, which should be fine I think/hope 😅
Co-authored-by: Charly Gomez <[email protected]>
Ensure it only changes if actual dependencies change.
Previously, we would invalidate the dependency cache every time a package.json of the workspace changed in any way. This is defensive, but it also means that we also invalidate if one of these things happen:
This change updates this to calculate the hash with a slightly more sophisticated approach, which should hopefully ensure we only actually bust the cache when a dependency actually changes. This should lead to the dependency cache being re-used much more, because only rarely is an actual dependency changed.