fix(node): ignore error rethrows in local variables integration #13418
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13416.
We ignore debugger call stacks in the worker that don't match the original error's call stack.
This should happen in just one of two ways, from my knowledge:
new Error()
but then thrown at a different location. We might want to capture the variables in this case? But with the current implementation the stack length won't match anyways unless we get lucky -- so we already won't capture variables from this case.No tests were added, and I imagine maintainers will have a broader depth of knowledge to know if this is a good idea or not - but hoping this gets someone else 90% of the way to fixing this. It functions as expected when used in my application.
yarn lint
) & (yarn test
).