test(core): Switch to vitest #13458
Closed
test(core): Switch to vitest #13458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5x speed improvement!
Lms24
requested review from
AbhiPrasad,
a team and
s1gr1d
and removed request for
a team
|
oof I guess that's the reason why Node 14 tests are failing 😢 |
|
Soo, I'm not the first one running into the node v14 issue 😢 |
|
Yeah unfortunately we need to keep using jest for our core packages :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #13439
This PR converts the jest test in our core package to vitest.
Locally, this reduced the test run time from ~60s to ~20s, so by ~3x. In a follow-up PR, I'm gonna improve the offline transport tests to use fake timers which should further decrease test runtime.
closes #13434