test(browser): Add integration test for httpContextIntegration
#13553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lms24
commented
Sep 2, 2024
Comment on lines
+5
to
+7
| const integrations = Sentry.getDefaultIntegrations({}).filter( | ||
| defaultIntegration => defaultIntegration.name === 'HttpContext', | ||
| ); |
There was a problem hiding this comment.
Note: I isolated this similarly to how the SDK was initialized in the original issue so that only this integration is active.
We don't have to do this but given that all other tests that implicitly check on some of the fields are conventional Sentry.init SDK scenarios, I think we can leave it as-is.
s1gr1d
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While investigating #13536 I wrote a quick integration test to check that the
httpContextIntegrationworks as expected. This PR adds said test to our browser integration tests. We have other tests in which we implicitly check that url and user-agent are set but none forreferer, so I think this test has value.