-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(nuxt): Improve logs about adding Node option 'import' #13726
Merged
Merged
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
021077e
feat(nuxt): Improve logs about adding Node option 'import'
s1gr1d 7a4b212
Use path.relative
s1gr1d 4235d2a
use path.sep instead of / (windows support)
s1gr1d ecdc8eb
Merge branch 'refs/heads/develop' into sig/improve-console-messages
s1gr1d File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
@@ -1,6 +1,6 @@ | ||||||
import * as fs from 'fs'; | ||||||
import { afterEach, describe, expect, it, vi } from 'vitest'; | ||||||
import { findDefaultSdkInitFile } from '../../src/vite/utils'; | ||||||
import { findDefaultSdkInitFile, getStringSuffixDiff } from '../../src/vite/utils'; | ||||||
|
||||||
vi.mock('fs'); | ||||||
|
||||||
|
@@ -59,3 +59,29 @@ describe('findDefaultSdkInitFile', () => { | |||||
expect(result).toBe('sentry.server.config.js'); | ||||||
}); | ||||||
}); | ||||||
|
||||||
describe('getStringDiff', () => { | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. l:
Suggested change
|
||||||
it('should return the suffix of the longer string when there is a common prefix', () => { | ||||||
expect(getStringSuffixDiff('abcdef', 'abc')).toBe('def'); | ||||||
}); | ||||||
|
||||||
it('should return an empty string when both strings are identical', () => { | ||||||
expect(getStringSuffixDiff('abc', 'abc')).toBe(''); | ||||||
}); | ||||||
|
||||||
it('should return the entire longer string when the shorter string is empty', () => { | ||||||
expect(getStringSuffixDiff('abcdef', '')).toBe('abcdef'); | ||||||
}); | ||||||
|
||||||
it('should return the entire longer string when there is no overlap', () => { | ||||||
expect(getStringSuffixDiff('abcdef', 'ghijkl')).toBe('abcdef'); | ||||||
}); | ||||||
|
||||||
it('should return an empty string when the longer string is empty', () => { | ||||||
expect(getStringSuffixDiff('', 'abc')).toBe(''); | ||||||
}); | ||||||
|
||||||
it('should return the suffix of the longer string when the shorter string is a prefix', () => { | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. l (no action required): what happens if the longer string is shorter (but not empty) that the shorter string param? 😅 |
||||||
expect(getStringSuffixDiff('abcdef', 'abcd')).toBe('ef'); | ||||||
}); | ||||||
}); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no strong opinions but shouldn't
path.relative
basically do what you're trying to do here? (I might be missing something though)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually yes 😅