Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Fix google-cloud-serverless URL in readme #13876

Merged
merged 2 commits into from
Oct 7, 2024
Merged

docs: Fix google-cloud-serverless URL in readme #13876

merged 2 commits into from
Oct 7, 2024

Conversation

lizhiyao
Copy link
Contributor

@lizhiyao lizhiyao commented Oct 5, 2024 •
edited
Loading

Before submitting a pull request, please take a look at our
Contributing guidelines and verify:

  • If you've added code that should be tested, please add tests.
  • Ensure your code lints and the test suite passes (yarn lint) & (yarn test).

@lizhiyao lizhiyao marked this pull request as draft October 5, 2024 02:48
@lizhiyao lizhiyao marked this pull request as ready for review October 5, 2024 02:50
@mydea mydea changed the title fix(readme): google-cloud-serverless url docs: Fix google-cloud-serverless URL in readme Oct 7, 2024
mydea
mydea approved these changes Oct 7, 2024
View reviewed changes
Copy link
Member

@mydea mydea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@mydea mydea enabled auto-merge (squash) October 7, 2024 08:36
@mydea mydea merged commit 21a01f8 into getsentry:develop Oct 7, 2024
97 checks passed
@github-actions github-actions bot mentioned this pull request Oct 7, 2024
Merged
AbhiPrasad pushed a commit that referenced this pull request Oct 7, 2024
@github-actions @mydea
ref: Add external contributor to CHANGELOG.md (#13883)
0c560a5 
This PR adds the external contributor to the CHANGELOG.md file, so that
they are credited for their contribution. See #13876

Co-authored-by: mydea <[email protected]>
@lizhiyao lizhiyao deleted the fix-readme-google-cloud-serverless-url branch October 12, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mydea mydea mydea approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lizhiyao @mydea