feat(nextjs/vercel-edge/cloudflare): Switch to OTEL for performance monitoring #13889
+918
−387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**This PR is part of a stacked PR sequence as we need to do many changes at once for #8105. Merging this PR as is will create inconsistent data.** --- This PR will make the `@sentry/vercel-edge` SDK use OpenTelemetry performance under the hood. We need to employ a few hacks so that OpenTelemetry works on a worker runtime: - We are vendoring the OTEL `AsyncLocalStorageContextManage` because the original implementation depends on `AsyncLocalStorage` as exported from `async_hooks` which is not available in workers. In our vendored version we are taking it from `globalThis.AsyncLocalStorage`. - We are polyfilling `performance` with `Date.now()` as that API is not available in worker runtimes. Resolves #13740
size-limit report 📦
|
…13890) Simply moves all runtime agnostic instrumentation related to the pages router into its own folder.
…13904) Drop all spans/transactions emitted by Next.js for pages router API routes because they are currently super buggy with wrong timestamps. Fix pending: vercel/next.js#70908 This is just a bit of prep-work so we can at some point disable the logic where we turn on all Next.js spans and still have high quality data.
Disables the instrumentation for incoming HTTP requests to be consistent across Next.js versions for instrumentation. Next 13 and 15 work with the HTTP instrumentation. 14 doesn't.
…time (#13919) We need to hoist the isolation scope forking logic out of the build-time instrumentation.
…runtime (#13921) We need to hoist the isolation scope forking logic out of the build-time instrumentation.
❌ 1 Tests Failed:
View the top 1 failed tests by shortest run time
To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a collection of PRs enabling OTEL tracing for
@sentry/nextjs,@sentry/vercel-edge, and by extension@sentry/cloudflare.Tasks:
@sentry/vercel-edge#13742)