Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Ensure we check correctly for bot users #13955

Merged
merged 1 commit into from
Oct 11, 2024
Merged

Conversation

mydea
Copy link
Member

@mydea mydea commented Oct 11, 2024

It seems that github.actor is not necessarily the PR author, but possibly the user that merged the PR.

You can see e.g. here: https://github.com/getsentry/sentry-javascript/actions/runs/11270299315/job/31340702772 how it still ran for a dependabot PR.

It seems that `github.actor` is not necessarily the PR author, but possibly the user that merged the PR.
@mydea mydea requested review from lforst and s1gr1d October 11, 2024 11:13
@mydea mydea self-assigned this Oct 11, 2024
Copy link
Contributor

size-limit report 📦

⚠️ Warning: Base artifact is not the latest one, because the latest workflow run is not done yet. This may lead to incorrect results. Try to re-run all tests to get up to date results.

Path Size % Change Change
@sentry/browser 22.73 KB - -
@sentry/browser - with treeshaking flags 21.53 KB - -
@sentry/browser (incl. Tracing) 34.97 KB - -
@sentry/browser (incl. Tracing, Replay) 71.62 KB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 62.03 KB - -
@sentry/browser (incl. Tracing, Replay with Canvas) 75.97 KB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 88.73 KB - -
@sentry/browser (incl. Tracing, Replay, Feedback, metrics) 90.59 KB - -
@sentry/browser (incl. metrics) 27 KB - -
@sentry/browser (incl. Feedback) 39.87 KB - -
@sentry/browser (incl. sendFeedback) 27.38 KB - -
@sentry/browser (incl. FeedbackAsync) 32.17 KB - -
@sentry/react 25.49 KB - -
@sentry/react (incl. Tracing) 37.94 KB - -
@sentry/vue 26.91 KB - -
@sentry/vue (incl. Tracing) 36.86 KB - -
@sentry/svelte 22.87 KB - -
CDN Bundle 24.05 KB - -
CDN Bundle (incl. Tracing) 36.76 KB - -
CDN Bundle (incl. Tracing, Replay) 71.38 KB - -
CDN Bundle (incl. Tracing, Replay, Feedback) 76.7 KB - -
CDN Bundle - uncompressed 70.53 KB - -
CDN Bundle (incl. Tracing) - uncompressed 109.04 KB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 221.4 KB - -
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 234.62 KB - -
@sentry/nextjs (client) 37.91 KB - -
@sentry/sveltekit (client) 35.56 KB - -
@sentry/node 124.9 KB +0.32% +403 B 🔺
@sentry/node - without tracing 94.13 KB +0.53% +501 B 🔺
@sentry/aws-serverless 103.7 KB +0.4% +414 B 🔺

View base workflow run

@mydea mydea merged commit 26ec075 into develop Oct 11, 2024
151 checks passed
@mydea mydea deleted the fn/check-for-pr-author branch October 11, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants