Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nextjs): Drop BaseServer.handleRequest without route #13957

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

lforst
Copy link
Member

@lforst lforst commented Oct 11, 2024

We can assume that BaseServer.handleRequest without route is always low-quality data so we can drop it.

Copy link
Contributor

size-limit report 📦

Path Size % Change Change
@sentry/browser 22.73 KB added added
@sentry/browser - with treeshaking flags 21.53 KB added added
@sentry/browser (incl. Tracing) 34.97 KB added added
@sentry/browser (incl. Tracing, Replay) 71.62 KB added added
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 62.03 KB added added
@sentry/browser (incl. Tracing, Replay with Canvas) 75.97 KB added added
@sentry/browser (incl. Tracing, Replay, Feedback) 88.73 KB added added
@sentry/browser (incl. Tracing, Replay, Feedback, metrics) 90.59 KB added added
@sentry/browser (incl. metrics) 27 KB added added
@sentry/browser (incl. Feedback) 39.87 KB added added
@sentry/browser (incl. sendFeedback) 27.38 KB added added
@sentry/browser (incl. FeedbackAsync) 32.17 KB added added
@sentry/react 25.49 KB added added
@sentry/react (incl. Tracing) 37.94 KB added added
@sentry/vue 26.9 KB added added
@sentry/vue (incl. Tracing) 36.86 KB added added
@sentry/svelte 22.87 KB added added
CDN Bundle 24.05 KB added added
CDN Bundle (incl. Tracing) 36.76 KB added added
CDN Bundle (incl. Tracing, Replay) 71.38 KB added added
CDN Bundle (incl. Tracing, Replay, Feedback) 76.7 KB added added
CDN Bundle - uncompressed 70.53 KB added added
CDN Bundle (incl. Tracing) - uncompressed 109.04 KB added added
CDN Bundle (incl. Tracing, Replay) - uncompressed 221.4 KB added added
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 234.62 KB added added
@sentry/nextjs (client) 37.91 KB added added
@sentry/sveltekit (client) 35.56 KB added added
@sentry/node 124.32 KB added added
@sentry/node - without tracing 93.41 KB added added
@sentry/aws-serverless 103.1 KB added added

Copy link

codecov bot commented Oct 11, 2024

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
230 1 229 14
View the top 1 failed tests by shortest run time
client-app-routing-instrumentation.test.ts Creates a navigation transaction for app router routes
Stack Traces | 30s run time
client-app-routing-instrumentation.test.ts:19:5 Creates a navigation transaction for app router routes

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

@lforst lforst requested a review from chargome October 14, 2024 08:48
@lforst lforst marked this pull request as ready for review October 14, 2024 08:51
@lforst lforst merged commit 88656c2 into lforst-nextjs-otel Oct 14, 2024
118 of 122 checks passed
@lforst lforst deleted the lforst-drop-unrouted-txns branch October 14, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants