Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nextjs): Don't drop transactions for server components on navigations #13980

Merged

Conversation

lforst
Copy link
Member

@lforst lforst commented Oct 15, 2024

We were dropping a few too many transactions.

Copy link
Contributor

github-actions bot commented Oct 15, 2024

size-limit report 📦

Path Size % Change Change
@sentry/browser 22.73 KB added added
@sentry/browser - with treeshaking flags 21.53 KB added added
@sentry/browser (incl. Tracing) 34.97 KB added added
@sentry/browser (incl. Tracing, Replay) 71.62 KB added added
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 62.03 KB added added
@sentry/browser (incl. Tracing, Replay with Canvas) 75.97 KB added added
@sentry/browser (incl. Tracing, Replay, Feedback) 88.73 KB added added
@sentry/browser (incl. Tracing, Replay, Feedback, metrics) 90.59 KB added added
@sentry/browser (incl. metrics) 27 KB added added
@sentry/browser (incl. Feedback) 39.87 KB added added
@sentry/browser (incl. sendFeedback) 27.38 KB added added
@sentry/browser (incl. FeedbackAsync) 32.17 KB added added
@sentry/react 25.49 KB added added
@sentry/react (incl. Tracing) 37.94 KB added added
@sentry/vue 26.9 KB added added
@sentry/vue (incl. Tracing) 36.86 KB added added
@sentry/svelte 22.87 KB added added
CDN Bundle 24.05 KB added added
CDN Bundle (incl. Tracing) 36.76 KB added added
CDN Bundle (incl. Tracing, Replay) 71.38 KB added added
CDN Bundle (incl. Tracing, Replay, Feedback) 76.7 KB added added
CDN Bundle - uncompressed 70.53 KB added added
CDN Bundle (incl. Tracing) - uncompressed 109.04 KB added added
CDN Bundle (incl. Tracing, Replay) - uncompressed 221.4 KB added added
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 234.62 KB added added
@sentry/nextjs (client) 37.91 KB added added
@sentry/sveltekit (client) 35.56 KB added added
@sentry/node 124.32 KB added added
@sentry/node - without tracing 93.41 KB added added
@sentry/aws-serverless 103.1 KB added added

Copy link

codecov bot commented Oct 15, 2024

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
230 1 229 14
View the top 1 failed tests by shortest run time
edge-route.test.ts Should create a transaction for edge routes
Stack Traces | 0.088s run time
edge-route.test.ts:4:5 Should create a transaction for edge routes

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

@lforst lforst requested a review from chargome October 15, 2024 10:09
transactionEvent?.transaction === 'GET /api/edge-endpoint' && transactionEvent?.contexts?.trace?.status === 'ok'
transactionEvent?.transaction === 'GET /api/edge-endpoint' &&
transactionEvent?.contexts?.trace?.status === 'ok' &&
transactionEvent.contexts?.runtime?.name === 'vercel-edge'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tangentially related

@lforst lforst marked this pull request as ready for review October 15, 2024 10:09
@lforst lforst merged commit e979c75 into lforst-nextjs-otel Oct 15, 2024
118 checks passed
@lforst lforst deleted the lforst-nextjs-otel-fix-app-router-navigation-txns branch October 15, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant