Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(react-router): Add build-time config #15406

Open
wants to merge 16 commits into
base: develop
Choose a base branch
from

Conversation

chargome
Copy link
Member

@chargome chargome commented Feb 13, 2025

  • Adds a vite plugin for react router that handles:
    • Updating sourcemap settings
    • Release injection
    • Telemetry Data
  • Adds a sentryOnBuildEnd hook that handles:
    • Creating releases
    • DebugId injection
    • Uploading sourcemaps
    • Deleting sourcemaps after upload

Currently the options passed to both the plugin and the hook partly overlap which is confusing, would be nice to just have one common options object at the end. Actually I can pass these options via vite and read them in the hook

We'll need to revisit this and move DebugId injection back to the vite plugin to avoid modifying the final build. For the alpha release we'll still rely on the SentryCli.

closes #15188

@chargome chargome self-assigned this Feb 13, 2025
Copy link

codecov bot commented Feb 13, 2025

❌ 2 Tests Failed:

Tests completed Failed Passed Skipped
4662 2 4660 324
View the top 2 failed test(s) by shortest run time
test/integration/test/client/root-loader.test.ts should throw redirect to an external path with no baggage and trace injected.
Stack Traces | 0.079s run time
root-loader.test.ts:177:1 should throw redirect to an external path with no baggage and trace injected.
test/integration/test/client/root-loader.test.ts should return redirect to an external path with no baggage and trace injected.
Stack Traces | 0.11s run time
root-loader.test.ts:165:1 should return redirect to an external path with no baggage and trace injected.

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@chargome chargome force-pushed the cg/rr-build-time-config branch from 152b618 to dca9d06 Compare February 17, 2025 09:08
@chargome chargome changed the title feat(react-router): Add vite plugin feat(react-router): Add build-time config Feb 21, 2025
@chargome chargome marked this pull request as ready for review February 24, 2025 14:13
@chargome chargome requested review from s1gr1d, a team, stephanie-anderson and Lms24 and removed request for a team and stephanie-anderson February 24, 2025 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RR7] Add build time configuration
1 participant