feat(core): Rename inboundFiltersIntegration to eventFiltersIntegration
#15434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lms24
commented
Feb 17, 2025
Comment on lines
+36
to
37
| // TODO(v10): Replace with `eventFiltersIntegration` once we remove the deprecated `inboundFiltersIntegration` | ||
| inboundFiltersIntegration(), |
There was a problem hiding this comment.
Wherever we currently add inboundFiltersIntegration as a default integration, we can't simply swap it out. This is because it would break people filtering out the integration by its name. IMHO it's perfectly fine to keep this until the next major (or whenever we decide to remove the old name export) and then make the swap.
size-limit report 📦
|
s1gr1d
approved these changes
Feb 18, 2025
There was a problem hiding this comment.
I think this is a valid case for renaming as this integration is different from the Inbound Filters in the UI.
|
Yup, that's one of my two reasons as for why I think we should rename this integration. I updated the issue with some reasons as to why I think the current name is suboptimal. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening as a draft for now for feedback. Happy to close if folks have concerns.
See #15431 for reasons for the renaming
ref #15431