feat(logs): Add experimental user-callable logging methods #15442
+351
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
colin-sentry
force-pushed
the
colin/log-api
branch
from
1328016 to
c5eb7fe
Compare
| @@ -223,6 +223,7 @@ const ITEM_TYPE_TO_DATA_CATEGORY_MAP: Record<EnvelopeItemType, DataCategory> = { | |||
| feedback: 'feedback', | |||
| span: 'span', | |||
| raw_security: 'security', | |||
| otel_log: 'log_item', | |||
There was a problem hiding this comment.
Will there be any other type than otel_log? If not in the foreseeable future, I'd suggest we change it to
Suggested change
| otel_log: 'log_item', | |
| log: 'log', |
Again singular, as in span, or replay
There was a problem hiding this comment.
This is done because it matches the code in relay for data categories (rate limiting and client outcomes) https://github.com/getsentry/relay/blob/e36886a98c89af645e5c0d2109657deafa25d902/relay-server/src/envelope.rs#L182
❌ 1 Tests Failed:
View the top 1 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
AbhiPrasad
changed the title
colin-sentry
commented
Feb 20, 2025
packages/core/src/log.ts
Outdated
|
|
||
| const SEVERITY_TEXT_TO_SEVERITY_NUMBER: Partial<Record<LogSeverityLevel | 'log', number>> = { | ||
| trace: 1, | ||
| log: 2, |
There was a problem hiding this comment.
I wouldn't expect sentry.log to be lower priority than sentry.debug - is this actually what otel says?
There was a problem hiding this comment.
I put this in the wrong place 🤦
just saw it while I saw debugging, more reason to add tests for this
k-fish
reviewed
Feb 20, 2025
packages/core/src/log.ts
Outdated
Comment on lines
17
to
23
| trace: 1, | ||
| log: 2, | ||
| debug: 5, | ||
| info: 9, | ||
| warn: 13, | ||
| error: 17, | ||
| fatal: 21, |
There was a problem hiding this comment.
Suggested change
| trace: 1, | |
| log: 2, | |
| debug: 5, | |
| info: 9, | |
| warn: 13, | |
| error: 17, | |
| fatal: 21, | |
| trace: 1, | |
| debug: 5, | |
| info: 9, | |
| log: 10, | |
| warn: 13, | |
| error: 17, | |
| fatal: 21, |
AbhiPrasad
force-pushed
the
colin/log-api
branch
from
2a02335 to
3e936c9
Compare
|
It's strange how this impacts bundle size. I would have expected the additional code to tree-shake out when it's not used! Why is the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds logging APIs to the SDK. At the moment this is only exposed in
@sentry/coreand@sentry/browser.Logging is gated by an experimental option,
_experiments.enableLogs. Just picked this for now, name is subject to change.These API are exposed in the
Sentry._experiment_lognamespace.On the high level, there are functions for each of the logging severity levels
critical,fatal,error,warn,info,debug,trace. These functions are tagged template functions, so they use a special string template syntax that we use to parameterize functions accordingly.If you want more custom usage, we also expose a
captureLogmethod that allows you to pass custom attributes, but it's less easy to use than the tagged template functions.There is a buffer of logs that flushes every 5 seconds, or when you hit 25 logs, whichever comes first.