Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(node-integration): Migrate to Vitest #15499

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

timfish
Copy link
Collaborator

@timfish timfish commented Feb 25, 2025

Vitest doesn't support the done callback that most integration tests used with Jest.

This PR:

  • Modify all tests to:
    • Use Vitest imports
    • Be async
  • Changes test runner and test server to be async
    • runner.start(done) becomes runner.start().completed(): Promise<void>
    • createTestServer() close function now throws any errors that occurred

@timfish timfish marked this pull request as ready for review February 25, 2025 22:36
@timfish timfish requested a review from AbhiPrasad February 25, 2025 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant