Skip to content

Commit

Permalink
fix(crons): Correct description of start_time (#383)
Browse files Browse the repository at this point in the history
This actually is NOT when relay kafka produces the message into kafka
(we can use the headers timestamp for that, since w're configured for
LogAppendTime)

Here's where this is actually coming from

https://github.com/getsentry/relay/blob/671bdf354b1fdc401d1a1c39430b7b1da3e70cec/relay-server/src/services/store.rs#L845

Where the `start_time` here actually comes from the managed envelope

https://github.com/getsentry/relay/blob/671bdf354b1fdc401d1a1c39430b7b1da3e70cec/relay-server/src/services/store.rs#L175

Which comes from the actual envelope store request start_time

https://github.com/getsentry/relay/blob/671bdf354b1fdc401d1a1c39430b7b1da3e70cec/relay-server/src/utils/managed_envelope.rs#L495-L500
  • Loading branch information
evanpurkhiser authored Feb 11, 2025
1 parent 0244f54 commit 179dfe6
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion schemas/ingest-monitors.v1.schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
"$bytes": true
},
"start_time": {
"description": "The time relay produced the check-in to kafka. In seconds with floating precision.",
"description": "The time relay received the envelope containing the check-in. In seconds.",
"type": "number"
},
"project_id": {
Expand Down

0 comments on commit 179dfe6

Please sign in to comment.