make create_event conditionally use both helpers

getsentry · Oct 17, 2024 · 2fc4061 · 2fc4061
1 parent c740024
commit 2fc4061
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 4 deletions.
diff --git a/tests/sentry/grouping/__init__.py b/tests/sentry/grouping/__init__.py
@@ -73,7 +73,12 @@ def _save_event_with_pipeline(
         ):
             return save_new_event(self.data, project)
 
-    def create_event(self, config_name: str) -> Event:
+    def create_event(
+        self,
+        config_name: str,
+        use_full_ingest_pipeline: bool = True,
+        project: Project | None = None,
+    ) -> Event:
         grouping_config = get_default_grouping_config_dict(config_name)
 
         # Add in any extra grouping configuration from the input data
@@ -86,7 +91,11 @@ def create_event(self, config_name: str) -> Event:
             bases=CONFIGURATIONS[config_name].fingerprinting_bases,
         )
 
-        event = self._manually_save_event(grouping_config, fingerprinting_config)
+        if use_full_ingest_pipeline:
+            assert project, "'project' is required to use full pipeline"
+            event = self._save_event_with_pipeline(grouping_config, fingerprinting_config, project)
+        else:
+            event = self._manually_save_event(grouping_config, fingerprinting_config)
 
         return event
 

diff --git a/tests/sentry/grouping/test_benchmark.py b/tests/sentry/grouping/test_benchmark.py
@@ -31,7 +31,7 @@ def setup():
 
 
 def run_configuration(grouping_input: GroupingInput, config_name: str) -> None:
-    event = grouping_input.create_event(config_name)
+    event = grouping_input.create_event(config_name, use_full_ingest_pipeline=False)
 
     # This ensures we won't try to touch the DB when getting event hashes
     event.project = None  # type: ignore[assignment]

diff --git a/tests/sentry/grouping/test_variants.py b/tests/sentry/grouping/test_variants.py
@@ -64,7 +64,7 @@ def _dump_component(component: GroupingComponent, indent: int) -> None:
 def test_event_hash_variant(
     config_name: str, grouping_input: GroupingInput, insta_snapshot: InstaSnapshotter
 ) -> None:
-    event = grouping_input.create_event(config_name)
+    event = grouping_input.create_event(config_name, use_full_ingest_pipeline=False)
 
     # This ensures we won't try to touch the DB when getting event variants
     event.project = None  # type: ignore[assignment]