Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(settings): Convert org members list to FC #76370

Merged
merged 16 commits into from
Oct 17, 2024

Conversation

scttcper
Copy link
Member

@scttcper scttcper commented Aug 16, 2024

this component was using AsyncComponent's renderSearchInput

combines the organizationMembersWrapper into the organizationMembers component instead of using the router to pass in some loaded data from above.

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Aug 16, 2024
@getsantry
Copy link
Contributor

getsantry bot commented Sep 7, 2024

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you add the label WIP, I will leave it alone unless WIP is removed ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added Stale and removed Stale labels Sep 7, 2024
@getsantry
Copy link
Contributor

getsantry bot commented Sep 30, 2024

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you add the label WIP, I will leave it alone unless WIP is removed ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added the Stale label Sep 30, 2024
@scttcper scttcper added WIP and removed Stale labels Sep 30, 2024
# Conflicts:
#	static/app/views/settings/organizationMembers/organizationMembersList.tsx
#	static/app/views/settings/organizationMembers/organizationMembersWrapper.tsx
Copy link

codecov bot commented Sep 30, 2024

❌ 2 Tests Failed:

Tests completed Failed Passed Skipped
7912 2 7910 0
View the top 2 failed tests by shortest run time
OrganizationMembersList can redirect to remaining org after leaving OrganizationMembersList can redirect to remaining org after leaving
Stack Traces | 0.27s run time
Error: expect(jest.fn()).toHaveBeenCalledTimes(expected)

Expected number of calls: 1
Received number of calls: 0
    at Object.<anonymous> (.../settings/organizationMembers/organizationMembersList.spec.tsx:250:25)
OrganizationMembersList can leave org OrganizationMembersList can leave org
Stack Traces | 0.356s run time
Error: expect(jest.fn()).toHaveBeenCalledTimes(expected)

Expected number of calls: 1
Received number of calls: 0
    at Object.<anonymous> (.../settings/organizationMembers/organizationMembersList.spec.tsx:221:25)

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

@scttcper scttcper removed the WIP label Sep 30, 2024
@scttcper scttcper requested a review from a team September 30, 2024 23:41
@scttcper scttcper marked this pull request as ready for review September 30, 2024 23:41

// Only admins/owners can remove members
const requireLink = !!this.state.authProvider && this.state.authProvider.require_link;
const handleQueryChange = (query: string) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we want to use useCallback for these functions?

@scttcper scttcper changed the title feat(settings): Convert org members list to functional feat(settings): Convert org members list to FC Oct 7, 2024
Copy link
Member

@malwilley malwilley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't test everything, but searching and filtering members feels so much better now (page doesn't completely disappear) 🎉

@scttcper scttcper merged commit 2c32c2b into master Oct 17, 2024
43 checks passed
@scttcper scttcper deleted the scttcper/ref-fc-members-list branch October 17, 2024 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants