-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(settings): Convert org members list to FC #76370
Conversation
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you add the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you add the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
# Conflicts: # static/app/views/settings/organizationMembers/organizationMembersList.tsx # static/app/views/settings/organizationMembers/organizationMembersWrapper.tsx
❌ 2 Tests Failed:
View the top 2 failed tests by shortest run time
To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard |
static/app/views/settings/organizationMembers/inviteRequestRow.tsx
Outdated
Show resolved
Hide resolved
|
||
// Only admins/owners can remove members | ||
const requireLink = !!this.state.authProvider && this.state.authProvider.require_link; | ||
const handleQueryChange = (query: string) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we want to use useCallback
for these functions?
static/app/views/settings/organizationMembers/organizationMembersList.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't test everything, but searching and filtering members feels so much better now (page doesn't completely disappear) 🎉
this component was using AsyncComponent's
renderSearchInput
combines the organizationMembersWrapper into the organizationMembers component instead of using the router to pass in some loaded data from above.