feat(insights): filter mobile transactions #78855
Merged
+22
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
mjq
approved these changes
Oct 16, 2024
| 'app.lifecycle', | ||
| // navigation and pageload are seen in react-native | ||
| 'navigation', | ||
| 'pageload', |
There was a problem hiding this comment.
I wonder if there's anything else we could additionally filter on to get rid of browser navigations and pageloads 🤔 Anyway this PR is an improvement regardless, we can loop back later
There was a problem hiding this comment.
Yeah that would be great! Also, I think ideally we are able to filter by projects directly.
For example in the frontend view, we only show data for frontend projects. That way we don't have to worry about filtering by the right transaction ops, and custom transactions would work too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work for #77572
Filter mobile overview page by relevant transaction ops. This does not apply to the double chart rows, as some of them use span metrics, which means we cant filter them the same way due to missing tags.