Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(grouping): Add new grouping test inputs #78947

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

lobsterkatie
Copy link
Member

@lobsterkatie lobsterkatie commented Oct 10, 2024

This adds a number of new grouping variants inputs:

  • Two built-in fingerprint/chunkload error inputs: a base one and one with a hybrid fingerprint, to show that (in theory), the one with the hybrid fingerprint comes out with a different hash than the regular one. (I say in theory, because right now we have a bug in the system such that built-in fingerprints clobber the added part of a hybrid fingerprint. So the snapshots for these inputs do not in fact have different hashes, but once that bug is fixed, we'll be able to see that it is because the hybrid fingerprint version of the pair will have its hash change.)

  • Two custom fingerprint inputs to go along with the existing, client-fingerprint-only one, which has been renamed to reflect its relation to the two new ones: a server-side-rule-only input and an input which has both a client fingerprint and a server-side rule. These are again to illustrate what should theoretically be happening (but currently isn't), which is that the client and server-side fingerprints both work, and in the case where both exist, server-side fingerprinting takes precedence. As it stands, the client fingerprint works, the server-side one is totally ignored, and in the case with both, it's the client rather than the server-side fingerprint that wins (again because we're ignoring the server-side fingerprint) - but once this is fixed, we'll similarly have proof that it has been.

  • Five hybrid fingerprint inputs:

    • A set of three consisting of a base input, one that has the same added fingerprint value but different underlying data, and one that has the same underlying data but a different added fingerprint value. All three have different hashes, indicating that both the {{ default }} and the added parts are being taken into consideration.
    • A pair of inputs where there are both client fingerprints and server fingerprint rules, and in each case one or the other is a hybrid fingerprint. For the same reasons as with the previous fingerprints-from-both-sources example, when the hybrid comes from the client, it's used, but when it comes from the server, it isn't. This is another place we'll be able to see that bug getting fixed.
  • A message-based-grouping input, with a message including numbers, to show that though the legacy config doesn't parameterize, the newstyle configs do.

It also adds a built-in fingerprint chunkload error input for use with the fingerprinting tests.

@github-actions github-actions bot added Scope: Frontend Automatically applied to PRs that change frontend components Scope: Backend Automatically applied to PRs that change backend components labels Oct 10, 2024

This comment was marked as off-topic.

@lobsterkatie lobsterkatie removed the Scope: Frontend Automatically applied to PRs that change frontend components label Oct 10, 2024
@lobsterkatie lobsterkatie changed the title add hybrid fingerprint variant test inputs feat(grouping): Add new grouping test inputs Oct 10, 2024
@lobsterkatie lobsterkatie marked this pull request as ready for review October 10, 2024 17:36
@lobsterkatie lobsterkatie requested a review from a team as a code owner October 10, 2024 17:36
Copy link
Member

@JoshFerge JoshFerge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@lobsterkatie lobsterkatie force-pushed the kmclb-add-fingerprint-and-parameterization-inputs-to-variant-tests branch from adba6be to 9a857b0 Compare October 16, 2024 15:05
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Oct 16, 2024
@lobsterkatie lobsterkatie changed the base branch from master to kmclb-refactor-grouping-snapshot-tests October 16, 2024 15:06
@lobsterkatie lobsterkatie removed the Scope: Frontend Automatically applied to PRs that change frontend components label Oct 16, 2024
@lobsterkatie lobsterkatie force-pushed the kmclb-refactor-grouping-snapshot-tests branch from 41be2d2 to 4dbb3c4 Compare October 17, 2024 20:16
@lobsterkatie lobsterkatie force-pushed the kmclb-add-fingerprint-and-parameterization-inputs-to-variant-tests branch from 9a857b0 to 9549c64 Compare October 17, 2024 20:16
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Oct 17, 2024
@lobsterkatie lobsterkatie force-pushed the kmclb-refactor-grouping-snapshot-tests branch from 4dbb3c4 to b0166d6 Compare October 17, 2024 21:00
@lobsterkatie lobsterkatie force-pushed the kmclb-add-fingerprint-and-parameterization-inputs-to-variant-tests branch from 9549c64 to 4934530 Compare October 17, 2024 21:00
Base automatically changed from kmclb-refactor-grouping-snapshot-tests to master October 17, 2024 23:18
@lobsterkatie lobsterkatie force-pushed the kmclb-add-fingerprint-and-parameterization-inputs-to-variant-tests branch from 4934530 to 7a50a39 Compare October 17, 2024 23:25
@lobsterkatie lobsterkatie removed the Scope: Frontend Automatically applied to PRs that change frontend components label Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants