-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(grouping): Add new grouping test inputs #78947
Open
lobsterkatie
wants to merge
6
commits into
master
Choose a base branch
from
kmclb-add-fingerprint-and-parameterization-inputs-to-variant-tests
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat(grouping): Add new grouping test inputs #78947
lobsterkatie
wants to merge
6
commits into
master
from
kmclb-add-fingerprint-and-parameterization-inputs-to-variant-tests
+8,031
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Scope: Frontend
Automatically applied to PRs that change frontend components
Scope: Backend
Automatically applied to PRs that change backend components
labels
Oct 10, 2024
This comment was marked as off-topic.
This comment was marked as off-topic.
lobsterkatie
removed
the
Scope: Frontend
Automatically applied to PRs that change frontend components
label
Oct 10, 2024
lobsterkatie
changed the title
add hybrid fingerprint variant test inputs
feat(grouping): Add new grouping test inputs
Oct 10, 2024
JoshFerge
approved these changes
Oct 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
lobsterkatie
force-pushed
the
kmclb-add-fingerprint-and-parameterization-inputs-to-variant-tests
branch
from
October 16, 2024 15:05
adba6be
to
9a857b0
Compare
github-actions
bot
added
the
Scope: Frontend
Automatically applied to PRs that change frontend components
label
Oct 16, 2024
lobsterkatie
changed the base branch from
master
to
kmclb-refactor-grouping-snapshot-tests
October 16, 2024 15:06
lobsterkatie
removed
the
Scope: Frontend
Automatically applied to PRs that change frontend components
label
Oct 16, 2024
lobsterkatie
force-pushed
the
kmclb-refactor-grouping-snapshot-tests
branch
from
October 17, 2024 20:16
41be2d2
to
4dbb3c4
Compare
lobsterkatie
force-pushed
the
kmclb-add-fingerprint-and-parameterization-inputs-to-variant-tests
branch
from
October 17, 2024 20:16
9a857b0
to
9549c64
Compare
github-actions
bot
added
the
Scope: Frontend
Automatically applied to PRs that change frontend components
label
Oct 17, 2024
lobsterkatie
force-pushed
the
kmclb-refactor-grouping-snapshot-tests
branch
from
October 17, 2024 21:00
4dbb3c4
to
b0166d6
Compare
lobsterkatie
force-pushed
the
kmclb-add-fingerprint-and-parameterization-inputs-to-variant-tests
branch
from
October 17, 2024 21:00
9549c64
to
4934530
Compare
Base automatically changed from
kmclb-refactor-grouping-snapshot-tests
to
master
October 17, 2024 23:18
lobsterkatie
force-pushed
the
kmclb-add-fingerprint-and-parameterization-inputs-to-variant-tests
branch
from
October 17, 2024 23:25
4934530
to
7a50a39
Compare
lobsterkatie
removed
the
Scope: Frontend
Automatically applied to PRs that change frontend components
label
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a number of new grouping variants inputs:
Two built-in fingerprint/chunkload error inputs: a base one and one with a hybrid fingerprint, to show that (in theory), the one with the hybrid fingerprint comes out with a different hash than the regular one. (I say in theory, because right now we have a bug in the system such that built-in fingerprints clobber the added part of a hybrid fingerprint. So the snapshots for these inputs do not in fact have different hashes, but once that bug is fixed, we'll be able to see that it is because the hybrid fingerprint version of the pair will have its hash change.)
Two custom fingerprint inputs to go along with the existing, client-fingerprint-only one, which has been renamed to reflect its relation to the two new ones: a server-side-rule-only input and an input which has both a client fingerprint and a server-side rule. These are again to illustrate what should theoretically be happening (but currently isn't), which is that the client and server-side fingerprints both work, and in the case where both exist, server-side fingerprinting takes precedence. As it stands, the client fingerprint works, the server-side one is totally ignored, and in the case with both, it's the client rather than the server-side fingerprint that wins (again because we're ignoring the server-side fingerprint) - but once this is fixed, we'll similarly have proof that it has been.
Five hybrid fingerprint inputs:
{{ default }}
and the added parts are being taken into consideration.A message-based-grouping input, with a message including numbers, to show that though the legacy config doesn't parameterize, the newstyle configs do.
It also adds a built-in fingerprint chunkload error input for use with the fingerprinting tests.