Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(integrations): metrics for on-call integrations: Pagerduty #79027

Merged
merged 9 commits into from
Oct 17, 2024

Conversation

mifu67
Copy link
Contributor

@mifu67 mifu67 commented Oct 11, 2024

Add logging via EventLifecycle and EventLifecycleMetric to Pagerduty.

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Oct 11, 2024
Copy link

codecov bot commented Oct 11, 2024

Codecov Report

Attention: Patch coverage is 90.90909% with 5 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/sentry/integrations/pagerduty/integration.py 75.00% 3 Missing ⚠️
src/sentry/integrations/on_call/spec.py 91.30% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           master   #79027    +/-   ##
========================================
  Coverage   78.29%   78.30%            
========================================
  Files        7132     7134     +2     
  Lines      313925   314302   +377     
  Branches    51246    51319    +73     
========================================
+ Hits       245794   246110   +316     
- Misses      61708    61749    +41     
- Partials     6423     6443    +20     

@mifu67 mifu67 marked this pull request as ready for review October 15, 2024 20:27
@mifu67 mifu67 requested review from a team as code owners October 15, 2024 20:27
@mifu67 mifu67 enabled auto-merge (squash) October 17, 2024 16:24
@mifu67 mifu67 disabled auto-merge October 17, 2024 16:24
@mifu67 mifu67 merged commit 889c589 into master Oct 17, 2024
50 checks passed
@mifu67 mifu67 deleted the mifu67/pagerduty-observability branch October 17, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants