-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(dynamic-sampling): adding org option for target sample rate #79090
feat(dynamic-sampling): adding org option for target sample rate #79090
Conversation
Can you also add a test that would check that this options is returned from the endpoint? Some of the existing tests can be extended in: |
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #79090 +/- ##
==========================================
- Coverage 78.34% 78.32% -0.03%
==========================================
Files 7125 7134 +9
Lines 314477 314243 -234
Branches 51356 51308 -48
==========================================
- Hits 246384 246117 -267
- Misses 61650 61681 +31
- Partials 6443 6445 +2 |
add tests for range validation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closes https://github.com/getsentry/projects/issues/203
Adds new org level option for
"targetSampleRate"
/"sentry:target_sample_rate"
with a default value from the constantTARGET_SAMPLE_RATE_DEFAULT
.