feat(quick-start): Add logic to skeleton - Part 2 #79179
Merged
+128
−48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… priscila/feat/quick-start/add-logic-to-skeleton-part-1
github-actions
bot
added
the
Scope: Frontend
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## priscila/feat/quick-start/add-new-design-skeleton-feedback #79179 +/- ##
==============================================================================================
- Coverage 78.26% 78.26% -0.01%
==============================================================================================
Files 7136 7136
Lines 314133 314149 +16
Branches 51293 51295 +2
==============================================================================================
- Hits 245871 245870 -1
- Misses 61836 61853 +17
Partials 6426 6426 |
…ack' into priscila/feat/quick-start/add-logic-to-skeleton-part-2
Base automatically changed from
priscila/feat/quick-start/add-new-design-skeleton-feedback
to
master
October 16, 2024 12:23
ArthurKnaus
approved these changes
Oct 17, 2024
| ) => { | ||
| if (p.hasQuickStartUpdatesFeature) { | ||
| return ( | ||
| <div {...p}> |
There was a problem hiding this comment.
You are spreading text & hasQuickStartUpdatesFeature onto the div . We should omit them.
… of github.com:getsentry/sentry into priscila/feat/quick-start/add-logic-to-skeleton-part-2
priscilawebdev
deleted the
priscila/feat/quick-start/add-logic-to-skeleton-part-2
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds logic for 'waiting' on events/errors and implements the task-skipping functionality.
Contributes to https://github.com/getsentry/projects/issues/259
Preview
Screen.Recording.2024-10-16.at.09.06.15.mov