create rc-processing-transaction

[kneeyo1]

This creates rc processing transactions redis cluster specifically for transactions. For now as part of the rollout, this only initializes the new eventstore.

[lynnagara]

there's a lot of places in code where you need to implement the dual writing, have you considered putting the dual writing logic in one place only inside the transaction_processing_store implementation, so that none of the callsites need to change when rolling this out?

[lynnagara]

do you also need to update line 520 to point at the transacations store?

[lynnagara]

i think there are a few more places in the codebase where this is needed.. e.g.

sentry/src/sentry/event_manager.py

Lines 1104 to 1107 in 939be86

	unprocessed = event_processing_store.get(
	cache_key_for_event({"project": event.project_id, "event_id": event.event_id}),
	unprocessed=True,
	)

can you check the whole codebase?

[lynnagara]

you have this if/else block twice in this file..

suggest to refactor to something like:

processing_store = transaction_processing_store if event_type == "transaction" else event_processing_store
processing_store.get(cache_key)
processing_store.store(data)
processing_store.delete_by_key(cache_key)

also, there needs to be a 3rd time, as line 509 also needs to go to either the event or transaction processing store

[kneeyo1]

i think there are a few more places in the codebase where this is needed.. e.g.

sentry/src/sentry/event_manager.py

Lines 1104 to 1107 in 939be86

	unprocessed = event_processing_store.get(
	cache_key_for_event({"project": event.project_id, "event_id": event.event_id}),
	unprocessed=True,
	)

can you check the whole codebase?

that is from the _nodestore_save_many function which checks first to ensure the event type is not a transaction

if event.get_event_type() not in ("transaction", "generic") and job["groups"]:

The rest of the references in the codebase are test cases (and reprocessing, which I'm not sure if it needs to be updated) but I think they don't need to know about the split