ref(ingest): more telemetry in event consumer #79206
Merged
+8
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add the event's `type` to the transaction, so that we can filter by it in Sentry - wrap two more operations near the end of the transaction, to help fill in an area that is blank in our existing instrumentation
github-actions
bot
added
the
Scope: Backend
lynnagara
approved these changes
Oct 17, 2024
| @@ -272,10 +274,15 @@ def process_event( | |||
| ) | |||
|
|
|||
| # remember for an 1 hour that we saved this event (deduplication protection) | |||
| cache.set(deduplication_key, "", CACHE_TIMEOUT) | |||
| with sentry_sdk.start_span(op="cache.set") as span: | |||
| span.set_data("deduplication_key", deduplication_key) | |||
There was a problem hiding this comment.
curious what this one is for.. do we actually need that?
There was a problem hiding this comment.
No, it was a "just-in-case" for debugging but yeah probably not useful. Removed it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
typeto the transaction, so that we can filter by it in Sentry