Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 chore(data-secrecy): update data secrecy tests & attempt to fix delete endpoint #79228

Merged
merged 2 commits into from
Oct 16, 2024

Conversation

iamrajjoshi
Copy link
Member

i am trying to use another way to get the waiver entry and delete it because i have a bizarre issue that i can't replicate where the delete method returns a 404 when the waiver exists.

also improved the tests

@iamrajjoshi iamrajjoshi self-assigned this Oct 16, 2024
@iamrajjoshi iamrajjoshi requested a review from a team as a code owner October 16, 2024 20:12
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Oct 16, 2024
Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #79228      +/-   ##
==========================================
- Coverage   78.31%   78.30%   -0.02%     
==========================================
  Files        7134     7133       -1     
  Lines      314387   314463      +76     
  Branches    51336    51354      +18     
==========================================
+ Hits       246204   246227      +23     
- Misses      61746    61783      +37     
- Partials     6437     6453      +16     

Copy link
Member

@cathteng cathteng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤷‍♀️

@iamrajjoshi iamrajjoshi merged commit 5ed1ade into master Oct 16, 2024
50 of 51 checks passed
@iamrajjoshi iamrajjoshi deleted the raj/fix-data-secrecy-delete-endpoint branch October 16, 2024 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants