Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(alerts): Pass org instead of rule #79236

Merged
merged 2 commits into from
Oct 17, 2024

Conversation

ceorourke
Copy link
Member

We only ever use alert_rule.organization here so we can just pass the organization instead of the alert rule. As I'm writing the migration spec for ACI I noticed this and wanted to remove the reference to alert rule.

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Oct 16, 2024
@ceorourke ceorourke requested a review from a team October 16, 2024 21:01
Copy link

codecov bot commented Oct 16, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 6 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...seer/anomaly_detection/get_historical_anomalies.py 0.00% 2 Missing and 1 partial ⚠️
src/sentry/seer/anomaly_detection/store_data.py 0.00% 1 Missing and 1 partial ⚠️
src/sentry/seer/anomaly_detection/utils.py 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           master   #79236    +/-   ##
========================================
  Coverage   78.33%   78.33%            
========================================
  Files        7123     7125     +2     
  Lines      314393   314499   +106     
  Branches    51345    51366    +21     
========================================
+ Hits       246274   246361    +87     
- Misses      61674    61679     +5     
- Partials     6445     6459    +14     

Copy link
Contributor

@saponifi3d saponifi3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

really like this change - agree it will help simplify migration work with ACI too 🎉

@ceorourke ceorourke merged commit cc8c52a into master Oct 17, 2024
49 of 50 checks passed
@ceorourke ceorourke deleted the ceorourke/ref-anomaly-detection-alert-rule branch October 17, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants